fix(browser-repl): ensure that input can't be modified or evaluated while operation is in progress COMPASS-8256 #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hile operation is in progress
lerouxb
approved these changes
Sep 11, 2024
addaleax
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a slightly unexpected behavior in browser-repl right now where even though we don't allow user to type in shell input while operation is in progress, we don't disable the editor commands, and so it's still possible to run a command in parallel or choose a different input from history. Seems like this bug was there for awhile now, but we only noticed it now that we automatically run some commands in compass shell when opening a tab in certain contexts.