Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6176): add prebuilds in CI #7

Merged
merged 9 commits into from
May 29, 2024

Conversation

nbbeeken
Copy link
Collaborator

@nbbeeken nbbeeken commented May 23, 2024

Description

What is changing?

  • Add builds for all platforms
  • After all builds finish download and collect them
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Now, all builds can be a part of the "provenance" CI run that releases this package.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken force-pushed the NODE-6176-build-in-gha branch from b779384 to 37a3194 Compare May 23, 2024 18:39
@nbbeeken nbbeeken force-pushed the NODE-6176-build-in-gha branch 10 times, most recently from d15b27d to cca85a8 Compare May 24, 2024 14:24
@nbbeeken nbbeeken force-pushed the NODE-6176-build-in-gha branch from cca85a8 to b4e5489 Compare May 24, 2024 14:30
@nbbeeken nbbeeken force-pushed the NODE-6176-build-in-gha branch from ec86a68 to 992cd5a Compare May 24, 2024 14:55
@nbbeeken nbbeeken force-pushed the NODE-6176-build-in-gha branch from d7015ed to ad505a1 Compare May 24, 2024 15:52
@nbbeeken
Copy link
Collaborator Author

I verified on a spawn host that the Windows build on this PR loads on a Windows Server 2016 host.

@nbbeeken nbbeeken marked this pull request as ready for review May 24, 2024 17:40
@durran durran added the Team Review Needs review from team label May 28, 2024
@durran durran merged commit 09ccdd3 into chore-download May 29, 2024
6 of 7 checks passed
@durran durran deleted the NODE-6176-build-in-gha branch May 29, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants