Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(NODE-6185): Add test and lint tasks to CI #4

Merged
merged 17 commits into from
Jun 11, 2024
Merged

ci(NODE-6185): Add test and lint tasks to CI #4

merged 17 commits into from
Jun 11, 2024

Conversation

baileympearson
Copy link
Collaborator

@baileympearson baileympearson commented May 22, 2024 •
edited by nbbeeken
Loading

Description

What is changing?

  • Adds unit testing to build step
  • skips package test on all platforms other than ubuntu because tar was hanging, this still covers our expectations
Is there new documentation needed for these changes?

No

What is the motivation for this change?

Ensure we don't merge any unit test breaking changes

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title Create codeql.yml ci(NODE-6185): Add test and lint tasks to CI Jun 3, 2024
@baileympearson baileympearson marked this pull request as ready for review June 11, 2024 15:23
@nbbeeken nbbeeken self-requested a review June 11, 2024 15:26
@nbbeeken nbbeeken self-assigned this Jun 11, 2024
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 11, 2024
nbbeeken
nbbeeken approved these changes Jun 11, 2024
View reviewed changes
.github/workflows/lint.yml Show resolved Hide resolved
.github/docker/Dockerfile.glibc Outdated Show resolved Hide resolved
@baileympearson baileympearson requested a review from nbbeeken June 11, 2024 15:38
@nbbeeken nbbeeken merged commit 39d898a into mongodb-js:main Jun 11, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @nbbeeken