Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5908): support range v2 protocol #13

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

baileympearson
Copy link
Collaborator

@baileympearson baileympearson commented Jun 10, 2024

Description

What is changing?

All references to rangepreview have been renamed to range. Additionally, the feature flag for range v2 has been removed (confirmed with Kenn that supporint v1 is no longer necessary).

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

Support range v2 protocol

All references to rangepreview have been renamed to range. Additionally, the feature flag for range v2 has been removed.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson changed the title Create codeql.yml feat(NODE-5908): support range v2 protocol Jun 11, 2024
@baileympearson baileympearson marked this pull request as ready for review June 11, 2024 17:46
@W-A-James W-A-James self-assigned this Jun 11, 2024
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jun 11, 2024
Copy link
Contributor

@W-A-James W-A-James left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for clarity, is the implementation of the trimFactor parameter pointed out in the Jira ticket in the libmongocrypt repo?

@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jun 11, 2024
@durran
Copy link
Member

durran commented Jun 12, 2024

Just noting the collect CI action is removed in #9 as discussed.

@W-A-James W-A-James merged commit 4650f7c into main Jun 12, 2024
11 of 12 checks passed
@W-A-James W-A-James deleted the no-story-qe-v2 branch June 12, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants