Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compass-components): refactor ItemActionControls #2 #6560

Merged
merged 5 commits into from
Dec 20, 2024

Conversation

kraenhansen
Copy link
Contributor

@kraenhansen kraenhansen commented Dec 11, 2024

Description

Follow-up to #6552.

Merging this PR will:

  • Replace &:not(:first-child) styling to add spacing between item action buttons with the use of flex gap on the container element.
  • Add strong typing for 3x onClick handlers accessing data-action attributes on the element being clicked.
  • Remove Actions generic type parameters where it didn't add additional guarantees
  • Provide default type argument for Actions generic type to simplify use internally in the ./actions directory.
  • Remove unneeded / extraneous memoization.

Checklist

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

@kraenhansen kraenhansen added no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) labels Dec 11, 2024
@kraenhansen kraenhansen self-assigned this Dec 11, 2024
@kraenhansen kraenhansen force-pushed the kh/refactor-item-action-control-2 branch from a1ce680 to f12d213 Compare December 13, 2024 23:11
@kraenhansen kraenhansen force-pushed the kh/refactor-item-action-control-2 branch from f12d213 to 0bcf8b4 Compare December 19, 2024 22:50
@kraenhansen kraenhansen force-pushed the kh/refactor-item-action-control-2 branch from 0bcf8b4 to 8e9e93c Compare December 20, 2024 13:07
@kraenhansen kraenhansen marked this pull request as ready for review December 20, 2024 13:07
@kraenhansen kraenhansen force-pushed the kh/refactor-item-action-control-2 branch from 8e9e93c to a555cee Compare December 20, 2024 14:52
@kraenhansen kraenhansen merged commit b7f100c into main Dec 20, 2024
30 checks passed
@kraenhansen kraenhansen deleted the kh/refactor-item-action-control-2 branch December 20, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release notes Fix or feature not for release notes no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants