Skip to content

Commit

Permalink
Merge pull request #1455 from moneymanagerex/v19
Browse files Browse the repository at this point in the history
clean up rate link and simplify donation link
  • Loading branch information
guanlisheng authored Nov 28, 2023
2 parents 317a71c + e361a59 commit 3d1130f
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 19 deletions.
2 changes: 1 addition & 1 deletion app/src/main/java/com/money/manager/ex/DonateActivity.java
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ protected void onDirectDonationClick() {

@OnClick(R.id.homepageButton)
protected void onHomepageClick() {
String siteUrl = "http://android.moneymanagerex.org/";
String siteUrl = "https://moneymanagerex.org/?utm_campaign=Application_Android";

Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(siteUrl));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,15 @@ public void onClick(View v) {
});

// rate application
/*
TextView txtRate = view.findViewById(R.id.textViewLinkRate);
text = "<u>" + txtRate.getText() + "</u>";
txtRate.setText(Html.fromHtml(text));
txtRate.setMovementMethod(LinkMovementMethod.getInstance());
OnClickListenerUrl clickListenerRate = new OnClickListenerUrl();
clickListenerRate.setUrl("http://play.google.com/store/apps/details?id=com.money.manager.ex");
txtRate.setOnClickListener(clickListenerRate);
*/

// application issue tracker
TextView txtIssues = view.findViewById(R.id.textViewIssuesTracker);
Expand Down
10 changes: 5 additions & 5 deletions app/src/main/java/com/money/manager/ex/home/MainActivity.java
Original file line number Diff line number Diff line change
Expand Up @@ -1084,11 +1084,11 @@ private ArrayList<DrawerMenuItem> getDrawerMenuItems() {
.withIconDrawable(uiHelper.getIcon(GoogleMaterial.Icon.gmd_settings)
.color(iconColor)));
// Donate
menuItems.add(new DrawerMenuItem().withId(R.id.menu_donate)
.withText(getString(R.string.donate))
.withIconDrawable(uiHelper.getIcon(GoogleMaterial.Icon.gmd_card_giftcard)
.color(iconColor))
.withDivider(Boolean.TRUE));
// menuItems.add(new DrawerMenuItem().withId(R.id.menu_donate)
// .withText(getString(R.string.donate))
// .withIconDrawable(uiHelper.getIcon(GoogleMaterial.Icon.gmd_card_giftcard)
// .color(iconColor))
// .withDivider(Boolean.TRUE));
// Help
menuItems.add(new DrawerMenuItem().withId(R.id.menu_about)
.withText(getString(R.string.about))
Expand Down
8 changes: 0 additions & 8 deletions app/src/main/res/layout/about_fragment.xml
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,6 @@
android:layout_marginTop="4dp"
android:text="@string/mmex_website"/>

<com.money.manager.ex.view.RobotoTextView
android:id="@+id/textViewLinkRate"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center_horizontal"
android:layout_marginTop="4dp"
android:text="@string/rate_application"/>

<com.money.manager.ex.view.RobotoTextView
android:id="@+id/textViewLinkFeedback"
android:layout_width="wrap_content"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@
<string name="update_available">Update available</string>
<string name="update_available_online">There is an updated database file available online. Would you like to update?</string>
<string name="currency_not_found">Currency not found</string>
<string name="homepage">Our homepage is http://android.moneymanagerex.org/</string>
<string name="homepage">Our homepage is https://moneymanagerex.org/</string>
<string name="current_database">Current database</string>
<string name="about_logcat_header">You can send us the application log by clicking the button below.</string>
<string name="transaction_type_filter">Filter by Transaction Type</string>
Expand Down
4 changes: 0 additions & 4 deletions app/src/main/res/xml/preferences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@
android:icon="@null"
android:key="@string/pref_database"
android:title="@string/database" />
<Preference
android:icon="@null"
android:key="@string/pref_donate"
android:title="@string/donate" />
<Preference
android:icon="@null"
android:key="@string/pref_version_name"
Expand Down

0 comments on commit 3d1130f

Please sign in to comment.