feat(Modal): allow accepting custom arias, allow passing ReactNode to ModalHeader's title #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
changed the title
talkor
approved these changes
Jan 6, 2025
| @@ -9,7 +9,12 @@ interface WithoutDescription { | |||
| interface WithDescription { | |||
| /** | |||
| * Descriptive text or content below the title. | |||
| * When supplied, would also add an aria-describedby attribute to the modal dialog element. | |||
| * - If you pass a **string**, this will automatically set an internally generated `aria-describedby` on the parent Modal. | |||
| */ | ||
| title: string; | ||
| title: string | React.ReactNode; |
There was a problem hiding this comment.
ElementContent? Or we don't want it because it's less descriptive?
There was a problem hiding this comment.
It's a good point, let's see if a request arises, and we can add it later.
I believe most of the use cases would be wrapped under a single div, to flex it and position it properly, and in worst case people can just use fragment.
I generally don't like the ElementContent rather than just saying ReactNode, I think it is a bit redundant.
YossiSaadi
deleted the
feat/yossi/new-modal-allow-passing-reactnode-to-title-prop-8129253861-allow-passing-aria-labelledby-and-aria-describedby--8129247306
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/8129253861
https://monday.monday.com/boards/3532714909/pulses/8129247306