fix: margin causing overflow & uncentered #2495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
requested changes
Oct 13, 2024
There was a problem hiding this comment.
Thanks @MrTanoshii ! But this line is still relevant since we want to text to be aligned with the other elements, as the <input> has padding
|
Closing as another PR seems to be better suited and accepted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Comment
vibe/packages/core/src/components/EditableTypography/EditableTypography.module.scss
Lines 7 to 8 in 52415f4
This doesn't seem to be needed anymore, the text and containers are centered without it but are off center with it.