fix(List): getting wrong tabIndex on initialization (#2648)

mondaycom · Dec 12, 2024 · 7aaaa73 · 7aaaa73
1 parent 3c3fe12
commit 7aaaa73
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/core/src/components/List/List.tsx b/packages/core/src/components/List/List.tsx
@@ -140,8 +140,8 @@ const List: VibeComponent<ListProps> & {
             return child;
           }
           const id = (child.props as { id: string }).id || `${overrideId}-item-${index}`;
-          const isFocusableItem = isListItem(childrenRefs.current[index]);
-
+          const currentRef = childrenRefs.current[index];
+          const isFocusableItem = currentRef === undefined || currentRef === null || isListItem(currentRef);
           return React.cloneElement(child, {
             // @ts-ignore not sure how to deal with ref here
             ref: ref => (childrenRefs.current[index] = ref),

diff --git a/packages/core/src/components/List/__tests__/__snapshots__/List.test.js.snap b/packages/core/src/components/List/__tests__/__snapshots__/List.test.js.snap
@@ -29,7 +29,7 @@ exports[`List renders correctly with list items 1`] = `
     onFocus={[Function]}
     onMouseEnter={[Function]}
     role="option"
-    tabIndex={-1}
+    tabIndex={0}
   >
     1
   </li>