Merge pull request #3 from monade/default-actions-with-options

Default actions with options

.gitignore

@@ -1,3 +1,5 @@
 /Gemfile.lock
 /log
 /tmp
+.tool-versions
+.vscode

.rubocop.yaml

@@ -0,0 +1,16 @@
+require:
+  - rubocop-rails
+
+Rails/SaveBang:
+  Enabled: true
+  Severity: error
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Metrics/BlockLength:
+  Exclude:
+    - "spec/**/*"
+
+Style/Documentation:
+  Enabled: false

Gemfile

@@ -5,3 +5,4 @@ gem 'solargraph'
 gem 'yard'
 gem 'sqlite3'
 gem 'rails'
+gem 'rubocop-rails', require: false

lib/solipsist/actions.rb

@@ -33,7 +33,7 @@ def default!(model, options = {}, &block)
       when 'create'
         _implicit_create_action(model, options, &block)
       when 'index', 'show'
-        render_default!(model, options = {}, &block)
+        render_default!(model, options, &block)
       else
         raise "No implicit action for #{params[:action]}"
       end
@@ -57,7 +57,8 @@ def _implicit_destroy_action(model, options)
     # @param [Hash] options
     def _implicit_create_action(model, options)
       model.save!
-      block_given? ? yield : _implicit_render(model, options)
+      merged_options = options.include?(:status) ? options : options.merge(status: :created)
+      block_given? ? yield : _implicit_render(model, merged_options)
     end
 
     # @param [Object] model

spec/solipsist/actions_spec.rb

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 describe PeopleController, type: :controller do
   let(:json_body) { JSON.parse(response.body) }
 
@@ -22,13 +25,33 @@
   end
 
   context 'POST /people' do
+    it 'default http status is 201' do
+      post :create, params: { name: 'aaaaaaa' }
+      expect(response).to have_http_status(:created)
+    end
+
     it 'creates an item' do
       expect do
         post :create, params: { name: 'aaaaaaa' }
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(:created)
         expect(json_body.dig('data', 'id')).to be_a(String)
       end.to change { Person.count }.by(1)
     end
+
+    context 'custom status' do
+      before do
+        class PeopleController < ApplicationController
+          def create
+            default! @person, { status: :ok }
+          end
+        end
+      end
+
+      it 'can use custom status' do
+        post :create, params: { name: 'aaaaaaa' }
+        expect(response).to have_http_status(:ok)
+      end
+    end
   end
 
   context 'PUT /people/:id' do
@@ -54,3 +77,4 @@
     end
   end
 end
+# rubocop:enable Metrics/BlockLength

spec/solipsist/mass_actions_spec.rb

@@ -1,5 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
+# rubocop:disable Metrics/BlockLength
 describe ArticlesController, type: :controller do
   let(:json_body) { JSON.parse(response.body) }
 
@@ -25,7 +28,7 @@
     it 'creates an item' do
       expect do
         post :create, params: { title: 'aaaaaaa' }
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(:created)
         expect(json_body.dig('data', 'id')).to be_a(String)
       end.to change { Article.count }.by(1)
     end
@@ -40,6 +43,21 @@
         expect(json_body.dig('data', 1, 'attributes', 'title')).to eq('123123')
       end.to change { Article.count }.by(2)
     end
+
+    context 'custom status' do
+      before do
+        class ArticlesController < ApplicationController
+          def create
+            default! @article, { status: :ok }
+          end
+        end
+      end
+
+      it 'can use custom status' do
+        post :create, params: { title: 'aaaaaaa' }
+        expect(response).to have_http_status(:ok)
+      end
+    end
   end
 
   context 'PUT /articles/:id' do
@@ -83,3 +101,4 @@
     end
   end
 end
+# rubocop:enable Metrics/BlockLength

spec/spec_helper.rb

@@ -21,7 +21,6 @@ class Application < Rails::Application
 RSpec::Expectations.configuration.warn_about_potential_false_positives = false
 
 Rails.application.config.eager_load = false
-Rails.application.config.active_record.legacy_connection_handling = false
 
 Dir[File.expand_path('../support/*.rb', __FILE__)].each { |f| require f }
 

spec/support/controllers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 
 class ApplicationController < ActionController::API
   include ActionController::MimeResponds