This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Adding support to shared tables #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support to shared tables
…ncluding_db_in_discover # Conflicts: # tap_redshift/__init__.py
…ncluding_db_in_discover # Conflicts: # tap_redshift/__init__.py
…ncluding_db_in_discover
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Redshift extractor works by first discovering what tables and views are available to sync. This is done by querying information_schema to get table names, columns, etc. However, metadata on shared table views are not available so the extractor fails. Additionally, shared database is set up in its own database on Redshift and we cannot connect to it directly.
So in this PR we are replacing the
INFORMATION_SCHEMA.TablesbySVV_ALL_TABLESand replacingINFORMATION_SCHEMA.ColumnsbySVV_ALL_COLUMNSthat shows shared tables information.The only limitation that we still have is that we still didn't get the table constraints/PKs for shared tables.