Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add Matcha CSS and clean up HTML/CSS some #125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

momijizukamori
Copy link
Owner

Not ready for merge yet (still needs dark mode images and I kind of want to throw a minimal background on the page body), but up for preview.

  • Standardized labels (capitalized, with a trailing : when input field is after the label)
  • Added Matcha CSS with some tweaks
  • Updated HTML to add Matcha classes and remove now-unnecessary elements
  • Updated a bunch of absolute positioning of elements to use flex instead

Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://momijizukamori.github.io/bookbinder-js/pr-preview/pr-125/
on branch gh-pages at 2024-11-22 22:14 UTC

@acestronautical
Copy link
Collaborator

I like Matcha CSS, but the UI probably needs a bigger facelift than this.

I've been wondering if a style similar to https://acestronautical.github.io/bookcover-js/ would make sense.

Except have three panels. |page/sig info panel| |pdf preview in middle| |settings pane on left|

@momijizukamori
Copy link
Owner Author

I think that would be too much info, too wide - I expect to get pushback on the width of this version honestly, even though I think it's a fairly reasonable content area.

I agree that we do still need to consider some bigger changes, UI-wise, but those are going to take a bunch of discussing, and in the meantime this is kind of a general sprucing-up and accessibility improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants