Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed folio duplexrotate - but at what cost... #111

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

momijizukamori
Copy link
Owner

No description provided.

Copy link

github-actions bot commented Mar 12, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://momijizukamori.github.io/bookbinder-js/pr-preview/pr-111/
on branch gh-pages at 2024-03-13 00:33 UTC

@acestronautical
Copy link
Collaborator

acestronautical commented Mar 12, 2024

Code looks reasonable, not sure I love the naming. ‘Alt’ is pretty generic and I think we use it elsewhere to maybe mean something else?

@momijizukamori
Copy link
Owner Author

Code looks reasonable, not sure I love the naming. ‘Alt’ is pretty generic and I think we use it elsewhere to maybe mean something else?

I think the one spot we use it was left over from my initial pass at trying to get folio working (like two years ago), but I will go back through.

@sithel
Copy link
Collaborator

sithel commented Mar 13, 2024

am too fried to review this tonight, sorry. Will pass on though that nonbinary_octopus (who had asked about it this afternoon) tested it and 👍 (which is mostly what I care about) -- will ask for version number bump for this this once url changes land

@acestronautical
Copy link
Collaborator

Do we need to remove the 'NOTE: Not currently working for folios, sorry! Use the old version for now.' text from html?

@acestronautical acestronautical self-requested a review March 13, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants