Fix merge #107
Merged
Fix merge #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acestronautical
requested review from
momijizukamori,
sithel and
cass-kazumori
as code owners
|
Can you do a quick filesize check? I feel like |
|
Not sure why the import is failing after switching to the cantoo version? It works fine on my local hosted version? File size seems the same for me, but I'm using a mostly text PDF |
Hopding has abandoned pdf-lib and cantoo-scribe/pdf-lib accepted my upstream fix cantoo-scribe/pdf-lib#48
acestronautical
force-pushed
the
fix-merge
branch
from
bb3644e to
bd33d7d
Compare
|
acestronautical
commented
Mar 8, 2024
acestronautical
commented
Mar 8, 2024
acestronautical
commented
Mar 8, 2024
acestronautical
force-pushed
the
fix-merge
branch
from
22f2112 to
f1d8ccb
Compare
acestronautical
force-pushed
the
fix-merge
branch
from
f1d8ccb to
bcde94a
Compare
acestronautical
commented
Mar 8, 2024
momijizukamori
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix merging to use copypages instead of embedPDF. This resolves a margin issue where margins were being used from the source and destination PDFs in a weird way.
Replace hopding/pdf-lib with the maintained cantoo-scribe/pdf-lib to which we have an upstreamed performance fix for copypages cantoo-scribe/pdf-lib#48
Perform an npm audit fix and npm update
improve upload performance by pulling some variables out of the page rotation loop