Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoning UI cleanup part 1 #159

Open
wants to merge 22 commits into
base: feat/mom-0.10
Choose a base branch
from
Open

Conversation

PeenScreeker
Copy link
Member

@PeenScreeker PeenScreeker commented Nov 23, 2024

This pull request implements several changes being tracked here:
momentum-mod/game#2122

This can likely be reviewed by changes rather than by commit, but the history is preserved in case reviewers would like to see how this PR relates to the checklists in issue 2122.

REQUIRES SIMULTANEOUS RED CHANGES

Main changes:

  • Only allow zoning UI to be opened when sv_cheats is enabled
  • Styling improvements to tab menu related to zoning (hide header, padding, footer contents)
  • Zoning UI styling improvements (bg colors, padding, indentation)
  • Reworked add/delete functionality
    • Buttons inline within tracklist tree
    • Add buttons no longer selection dependent (add checkpoint to arbitrary segment)
  • UX improvement for placing corners, set zone height
  • Better communication between UI and engine for point placement state

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@PeenScreeker PeenScreeker self-assigned this Nov 23, 2024
@tsa96
Copy link
Member

tsa96 commented Nov 23, 2024

Are you sure you're trying to merge into the correct branch?

@PeenScreeker PeenScreeker force-pushed the feat/zoning-UI-cleanup branch 2 times, most recently from 7c2eeb3 to fd44882 Compare November 26, 2024 21:21
@tsa96
Copy link
Member

tsa96 commented Nov 27, 2024

This PR still seems wrong, I think you're targeting the wrong branch!

@PeenScreeker PeenScreeker changed the base branch from refactor/0.10-timer to feat/mom-0.10 November 27, 2024 12:50
@PeenScreeker PeenScreeker marked this pull request as ready for review November 27, 2024 12:59
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only spotted one issue, rest is good. Big fan of how simple you've kept everything, super readable code.

scripts/pages/zoning/zoning.ts Outdated Show resolved Hide resolved
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay LGTM

@tsa96
Copy link
Member

tsa96 commented Dec 1, 2024

Yup still looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants