Rails 6 1 #100
Open
Rails 6 1 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A client had invalid credentials in the Gateway settings which resulted in a Mollie::RequestError. Let's only create a Mollie customer when the gateway is active. Using an ensure_mollie_customer after_save should also create Mollie customers for users that have been created in the time that is was inactive
…ribute Since the safe navigation operator does raise on undefined methods we should use try instead.
I was missing another piece of code from the mollie gateway gem. Even though I did some edit in spree views, I'm still using there `order_just_completed?` method to display a thank you message. This method needs `flash['order_completed']` to be true and is normally set in the checkout update action: https://github.com/spree/spree/blob/master/frontend/app/controllers/spree/checkout_controller.rb#L43 So, I'm guessing, setting it here to true would be a good thing to do. Wdyt?
This little PR fixes issue #95
|
You beat me to it @Oldharlem 👍 |
Haha pure necessity 💯 |
|
And... When this PR will be merged?! Thanks for the PR @Oldharlem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patches deprecated update_attributes method and introduces a new appraisal for rails 6.1