Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix Sonarqube audit error #69

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Chore: Fix Sonarqube audit error #69

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
caf7615
Merge pull request #58 from mollie/feature/MOL-431
Tung-Huynh-Shopmacher Sep 12, 2024
98efe1d
MOL-471: fixing get payment methods
tdang1-shopmacher Sep 19, 2024
5b90f02
Merge pull request #59 from mollie/bugfix/MOL-471
Tung-Huynh-Shopmacher Sep 19, 2024
eb01824
MOL-475: Connector should verify if mailaddress for banktransfer is s…
NghiaDTr Oct 1, 2024
fc677d6
Merge pull request #66 from mollie/bugfix/MOL-475
Tung-Huynh-Shopmacher Oct 2, 2024
11af8f6
Chore: Fix Sonarqube audit error
NghiaDTr Oct 2, 2024
57dd739
Merge branch 'main' into fix-sonar-audit
Tung-Huynh-Shopmacher Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions processor/src/validators/payment.validators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const validateCardToken = (cardToken: string | undefined, ctPayment: CTPayment):
};

export const validateBanktransfer = (paymentCustomFields: any, ctPayment: CTPayment): void => {
if (!paymentCustomFields?.billingAddress || !paymentCustomFields?.billingAddress?.email) {
if (!paymentCustomFields?.billingAddress?.email) {
throwError(
'validateBanktransfer',
'email is required for payment method banktransfer. Please make sure you have sent it in billingAddress.email of the custom field.',
Expand Down Expand Up @@ -192,7 +192,7 @@ export const checkValidRefundTransactionForCreate = (ctPayment: CTPayment): bool
throwError('checkValidRefundTransactionForCreate', 'No initial refund transaction found.');
}

if (!initialRefundTransaction?.amount || !initialRefundTransaction?.amount.centAmount) {
if (!initialRefundTransaction?.amount?.centAmount) {
throwError(
'checkValidRefundTransactionForCreate',
`No amount found in initial refund transaction, CommerceTools Transaction ID: ${initialRefundTransaction?.id}.`,
Expand Down