Fix Sonar Audit

mollie · Oct 3, 2024 · e12d5da · e12d5da
2 parents d77f9e2 + 91d4279
commit e12d5da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/processor/src/commercetools/action.commercetools.ts b/processor/src/commercetools/action.commercetools.ts
@@ -30,8 +30,8 @@ export const setCustomFields = (fieldName: string, fieldValue: string) => {
  */
 export const addInterfaceInteraction = (params: CreateInterfaceInteractionParams) => {
   const { sctm_action_type, sctm_request, sctm_response, sctm_id, sctm_created_at } = params;
-  const interfaceInteractionId = sctm_id || uuid();
-  const interfaceInteractionTimestamp = sctm_created_at || createDateNowString();
+  const interfaceInteractionId = sctm_id ?? uuid();
+  const interfaceInteractionTimestamp = sctm_created_at ?? createDateNowString();
 
   return {
     action: 'addInterfaceInteraction',

diff --git a/processor/src/utils/app.utils.ts b/processor/src/utils/app.utils.ts
@@ -32,7 +32,7 @@ export function parseStringToJsonObject(
   try {
     return JSON.parse(targetedString);
   } catch {
-    const errorMessage = `${errorPrefix || 'SCTM - PAYMENT PROCESSING'} - Failed to parse the JSON string from the custom field ${fieldName}.`;
+    const errorMessage = `${errorPrefix ?? 'SCTM - PAYMENT PROCESSING'} - Failed to parse the JSON string from the custom field ${fieldName}.`;
     logger.error(errorMessage, {
       commerceToolsId: commerceToolsId,
     });