Merge pull request #81 from mollie/feature/MOL-439/PICT-253

MOL-439/MOL-253: fix wrong data type validation
mollie · Oct 15, 2024 · 78be405 · 78be405
2 parents 75dedbd + 51ddfc3
commit 78be405
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/application/src/components/method-details/method-details-form.tsx b/application/src/components/method-details/method-details-form.tsx
@@ -65,7 +65,6 @@ const MethodDetailsForm = (props: TCustomObjectDetailsFormProps) => {
         onBlur={formik.handleBlur}
         isReadOnly={props.isReadOnly}
         horizontalConstraint={13}
-        isRequired={false}
         renderError={(errorKey) => {
           if (errorKey === 'invalidLength') {
             return intl.formatMessage(messages.fieldMethodNameInvalidLength);
@@ -91,7 +90,6 @@ const MethodDetailsForm = (props: TCustomObjectDetailsFormProps) => {
         onBlur={formik.handleBlur}
         isReadOnly={props.isReadOnly}
         horizontalConstraint={13}
-        isRequired={false}
         renderError={(errorKey) => {
           if (errorKey === 'invalidLength') {
             return intl.formatMessage(

diff --git a/application/src/components/method-details/method-details.tsx b/application/src/components/method-details/method-details.tsx
@@ -213,10 +213,7 @@ const MethodDetails = (props: TMethodDetailsProps) => {
                 />
                 <CustomFormModalPage.FormPrimaryButton
                   label={CustomFormModalPage.Intl.save}
-                  onClick={(event) => {
-                    event.preventDefault();
-                    formProps.submitForm();
-                  }}
+                  onClick={() => formProps.submitForm()}
                   isDisabled={
                     formProps.isSubmitting || !formProps.isDirty || !canManage
                   }

diff --git a/application/src/components/method-details/validate.ts b/application/src/components/method-details/validate.ts
@@ -33,7 +33,7 @@ const validate = (
   }
   if (
     !Number.isInteger(formikValues.displayOrder) ||
-    formikValues.displayOrder <= 0 ||
+    formikValues.displayOrder < 0 ||
     formikValues.displayOrder > 100
   ) {
     errors.displayOrder.isNotInteger = true;

diff --git a/application/src/hooks/use-mollie-connector/use-mollie-connector.ts b/application/src/hooks/use-mollie-connector/use-mollie-connector.ts
@@ -50,7 +50,7 @@ const convertMollieMethodToCustomMethod = (
     }, {} as Record<string, string>),
     imageUrl: method.image.svg,
     status: 'Inactive',
-    displayOrder: undefined,
+    displayOrder: 0,
   }));
 };