Rename debug

Add uuid
mollie · Jul 18, 2024 · 751d7cf · 751d7cf
1 parent 776df25
commit 751d7cf
Show file tree

Hide file tree

Showing 9 changed files with 33 additions and 19 deletions.
diff --git a/connect.yaml b/connect.yaml
@@ -11,8 +11,8 @@ deployAs:
           description: Commercetools Composable Commerce API region
           required: true
           default: "europe-west1.gcp"
-        - key: MOLLIE_DEBUG
-          description: Mollie PSP debug mode
+        - key: DEBUG
+          description: Debug mode (0 or 1)
           required: false
           default: "0"
       securedConfiguration:

diff --git a/processor/.env.example b/processor/.env.example
@@ -10,7 +10,7 @@ CTP_AUTH_URL=https://auth.<YOUR_CTP_REGION>.commercetools.com
 CTP_API_URL=https://api.<YOUR_CTP_REGION>.commercetools.com
 
 ## Mollie PSP credentials
-MOLLIE_DEBUG=<INTEGER_VALUE> ## Either 1 for enable or 0 for disable
+DEBUG=<INTEGER_VALUE> ## Either 1 for enable or 0 for disable
 MOLLIE_API_KEY=<YOUR_MOLLIE_API_KEY>
 MOLLIE_PROFILE_ID=<YOUR_MOLLIE_PROFILE_ID>
 

diff --git a/processor/.env.jest b/processor/.env.jest
@@ -8,4 +8,4 @@ CTP_REGION=europe-west1.gcp
 ## MOLLIE vars
 MOLLIE_API_KEY=12345678901234567890123456789012
 MOLLIE_PROFILE_ID=pfl_12345
-MOLLIE_DEBUG=1
+DEBUG=0
diff --git a/processor/package-lock.json b/processor/package-lock.json
diff --git a/processor/package.json b/processor/package.json
@@ -1,7 +1,7 @@
 {
   "name": "shopmacher-mollie-processor",
   "description": "Integration between commercetools and mollie payment service provider",
-  "version": "0.0.10",
+  "version": "0.0.11",
   "main": "index.js",
   "private": true,
   "scripts": {
@@ -70,6 +70,7 @@
     "dotenv": "^16.4.5",
     "express": "^4.19.2",
     "proxy-from-env": "^1.1.0",
+    "uuid": "^10.0.0",
     "validator": "^13.12.0"
   }
 }
diff --git a/processor/src/utils/config.utils.ts b/processor/src/utils/config.utils.ts
@@ -19,7 +19,7 @@ export const readConfiguration = () => {
     },
     mollie: {
       apiKey: process.env.MOLLIE_API_KEY as string,
-      debug: process.env.MOLLIE_DEBUG as string,
+      debug: process.env.DEBUG as string,
       profileId: process.env.MOLLIE_PROFILE_ID as string,
     },
   };

diff --git a/processor/src/validators/payment.validators.ts b/processor/src/validators/payment.validators.ts
@@ -51,10 +51,10 @@ export const hasValidPaymentMethod: (method: string | undefined) => boolean = (m
 /**
  * Checks the payment method input of a Commercetools Payment object.
  *
- * @param {CTPayment} CTPayment - The Commercetools Payment object to check.
  * @return {true | CustomError} An object containing the validation result.
  * The `isInvalid` property indicates if the payment method input is invalid.
  * The `errorMessage` property contains the error message if the input is invalid.
+ * @param ctPayment
  */
 export const checkPaymentMethodInput = (ctPayment: CTPayment): true | CustomError => {
   const CTPaymentMethod = ctPayment.paymentMethodInfo?.method ?? '';
@@ -137,7 +137,7 @@ export const validateCommerceToolsPaymentPayload = (action: string, ctPayment: C
 
   checkPaymentInterface(ctPayment);
 
-  checkPaymentMethodInput(ctPayment);
+  // checkPaymentMethodInput(ctPayment);
 
   checkAmountPlanned(ctPayment);
 };
diff --git a/processor/tests/utils/config.utils.spec.ts b/processor/tests/utils/config.utils.spec.ts
@@ -15,7 +15,7 @@ describe('Test src/utils/config.utils.ts', () => {
       },
       mollie: {
         apiKey: process.env.MOLLIE_API_KEY,
-        debug: process.env.MOLLIE_DEBUG,
+        debug: process.env.DEBUG,
         profileId: process.env.MOLLIE_PROFILE_ID,
       },
     });
@@ -51,8 +51,8 @@ describe('Test src/utils/config.utils.ts', () => {
     expect(() => readConfiguration()).toThrow(CustomError);
   });
 
-  test('should throw an error when MOLLIE_DEBUG is not defined', () => {
-    delete process.env.MOLLIE_DEBUG;
+  test('should throw an error when DEBUG is not defined', () => {
+    delete process.env.DEBUG;
     expect(() => readConfiguration()).toThrow(CustomError);
   });
 });
diff --git a/processor/tests/validators/helpers.validators.spec.ts b/processor/tests/validators/helpers.validators.spec.ts
@@ -234,7 +234,7 @@ describe('Test helpers.validators.ts', () => {
       },
       mollie: {
         apiKey: process.env.MOLLIE_API_KEY as string,
-        debug: (process.env.MOLLIE_DEBUG ?? '0') as string,
+        debug: (process.env.DEBUG ?? '0') as string,
         profileId: process.env.MOLLIE_PROFILE_ID as string,
       },
     };
@@ -254,7 +254,7 @@ describe('Test helpers.validators.ts', () => {
       },
       mollie: {
         apiKey: process.env.MOLLIE_API_KEY as string,
-        debug: (process.env.MOLLIE_DEBUG ?? '0') as string,
+        debug: (process.env.DEBUG ?? '0') as string,
         profileId: process.env.MOLLIE_PROFILE_ID as string,
       },
     };