Merge branch 'develop' into feature/MOL-18/PICT-195_add-minor-modific…

…ations
mollie · Jul 23, 2024 · 0af1ada · 0af1ada
2 parents 6ab3bc1 + 843c257
commit 0af1ada
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 20 deletions.
diff --git a/processor/src/utils/map.utils.ts b/processor/src/utils/map.utils.ts
@@ -142,6 +142,10 @@ export const createMollieCreatePaymentParams = (payment: Payment): PaymentCreate
     // captureMode: paymentRequest.captureMode ?? null, PICT-204 is on hold
     // captureDelay: paymentRequest.captureMode ?? null, PICT-204 is on hold
     applicationFee: paymentRequest.applicationFee ?? {},
+
+    // TODO: Conflicts between docs and Mollie API Client
+    // The official document pointed out that these 2 fields are supported
+    // But if we send them along with the payload even hard-coded the value, Mollie return with the error: "Non-existent body parameter 'profileId' or 'testmode'"
     // profileId: paymentRequest.profileId ?? null,
     // testmode: paymentRequest.testmode ?? null,
     ...specificParam,

diff --git a/processor/tests/utils/map.utils.spec.ts b/processor/tests/utils/map.utils.spec.ts
@@ -94,10 +94,8 @@ describe('createMollieCreatePaymentParams', () => {
       billingAddress: {},
       issuer: '',
       metadata: null,
-      profileId: null,
       restrictPaymentMethodsToCountry: null,
       shippingAddress: {},
-      testmode: null,
       cardToken: '',
       include: '',
     });
@@ -156,10 +154,8 @@ describe('createMollieCreatePaymentParams', () => {
       billingAddress: {},
       issuer: '',
       metadata: null,
-      profileId: null,
       restrictPaymentMethodsToCountry: null,
       shippingAddress: {},
-      testmode: null,
       cardToken: customFieldObject.cardToken,
       include: '',
     });
@@ -223,10 +219,8 @@ describe('createMollieCreatePaymentParams', () => {
       applicationFee: {},
       billingAddress: {},
       metadata: null,
-      profileId: null,
       restrictPaymentMethodsToCountry: null,
       shippingAddress: {},
-      testmode: null,
     });
   });
 
@@ -289,10 +283,8 @@ describe('createMollieCreatePaymentParams', () => {
       applicationFee: {},
       billingAddress: {},
       metadata: null,
-      profileId: null,
       restrictPaymentMethodsToCountry: null,
       shippingAddress: {},
-      testmode: null,
     });
   });
 
@@ -352,10 +344,8 @@ describe('createMollieCreatePaymentParams', () => {
       applicationFee: {},
       billingAddress: {},
       metadata: null,
-      profileId: null,
       restrictPaymentMethodsToCountry: null,
       shippingAddress: {},
-      testmode: null,
     });
   });
 
@@ -413,10 +403,8 @@ describe('createMollieCreatePaymentParams', () => {
       applicationFee: {},
       billingAddress: {},
       metadata: null,
-      profileId: null,
       restrictPaymentMethodsToCountry: null,
       shippingAddress: {},
-      testmode: null,
     });
   });
 
@@ -472,10 +460,8 @@ describe('createMollieCreatePaymentParams', () => {
       applicationFee: {},
       billingAddress: {},
       metadata: null,
-      profileId: null,
       restrictPaymentMethodsToCountry: null,
       shippingAddress: {},
-      testmode: null,
     });
   });
 
@@ -583,10 +569,8 @@ describe('createMollieCreatePaymentParams', () => {
       applicationFee: {},
       billingAddress: {},
       metadata: null,
-      profileId: null,
       restrictPaymentMethodsToCountry: null,
       shippingAddress: {},
-      testmode: null,
     });
   });
 
@@ -646,10 +630,8 @@ describe('createMollieCreatePaymentParams', () => {
       applicationFee: {},
       billingAddress: {},
       metadata: null,
-      profileId: null,
       restrictPaymentMethodsToCountry: null,
       shippingAddress: {},
-      testmode: null,
     });
   });
 
@@ -709,10 +691,8 @@ describe('createMollieCreatePaymentParams', () => {
       applicationFee: {},
       billingAddress: {},
       metadata: null,
-      profileId: null,
       restrictPaymentMethodsToCountry: null,
       shippingAddress: {},
-      testmode: null,
     });
   });
 });