NTR: fix broken refund composition after metadata change (#623)

mollie · Sep 22, 2023 · a7485fc · a7485fc
1 parent 9b7230f
commit a7485fc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/src/Components/RefundManager/Builder/RefundDataBuilder.php b/src/Components/RefundManager/Builder/RefundDataBuilder.php
@@ -275,7 +275,13 @@ private function getRefundedQuantity(string $mollieLineItemId, \Mollie\Api\Resou
                 continue;
             }
 
-            $metadata = RefundMetadata::fromArray($refund['metadata']);
+            $meta = $refund['metadata'];
+
+            if (is_string($meta)) {
+                $meta = json_decode($meta, true);
+            }
+
+            $metadata = RefundMetadata::fromArray($meta);
 
             # if we do have a FULL item refund then
             # we must NOT substract our item again.

diff --git a/src/Hydrator/RefundHydrator.php b/src/Hydrator/RefundHydrator.php
@@ -33,10 +33,10 @@ public function hydrate(Refund $refund, OrderEntity $order): array
             ];
         }
 
-        $metaData = '';
+        $metaData = [];
 
         if (property_exists($refund, 'metadata')) {
-            $metaData = (string)json_encode($refund->metadata);
+            $metaData = $refund->metadata;
         }
 
         $internalDescription = null;
@@ -70,7 +70,7 @@ public function hydrate(Refund $refund, OrderEntity $order): array
             'isProcessing' => $refund->isProcessing(),
             'isQueued' => $refund->isQueued(),
             'isTransferred' => $refund->isTransferred(),
-            'metadata' => json_decode($metaData, true),
+            'metadata' => $metaData,
         ];
     }
 }