NTR: add disallowed function checks to phpstan (#645)

.phpstan.neon

@@ -8,7 +8,22 @@ parameters:
         # legacy code that is not working with abstract/interface changes
         - ./src/Compatibility/Storefront/Route/PaymentMethodRoute/RemovePaymentMethodRoute63.php
         - ./src/Service/Mail/MailService63.php
+    disallowedFunctionCalls:
+        - function: 'var_dump()'
+          message: 'use some logger instead'
+        - function: 'var_export()'
+          message: 'use some logger instead'
+        - function: 'dd()'
+          message: 'use some logger instead'
+        - function: 'print_r()'
+          message: 'use some logger instead'
+        - function: 'putenv()'
+          message: 'might overwrite existing variables'
+
 services:
     - class: MolliePayments\PHPStan\Rules\NoManufacturerRule
       tags:
         - phpstan.rules.rule
+
+includes:
+    - vendor/spaze/phpstan-disallowed-calls/extension.neon

composer.json

@@ -68,12 +68,13 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^9.5",
-        "phpstan/phpstan": "1.8.2",
+        "phpstan/phpstan": "1.10.0",
         "friendsofphp/php-cs-fixer": "^2.18",
         "phpcompatibility/php-compatibility": "^9.3",
         "squizlabs/php_codesniffer": "^3.6",
         "infection/infection": "^0.25.4",
         "boxblinkracer/phpunuhi": "dev-main",
+        "spaze/phpstan-disallowed-calls": "^2.16",
         "shopware/core": "*",
         "shopware/administration": "*",
         "shopware/storefront": "*"