PIPRES-349: Subscription carrier data provider #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjas1997
reviewed
Dec 11, 2023
| return new UpdateSubscriptionData( | ||
| $data->getMollieCustomerId(), | ||
| $data->getMollieSubscriptionId(), | ||
| null, |
There was a problem hiding this comment.
Not sure about this null if it's really needed in any way
tomjas1997
approved these changes
Dec 11, 2023
Base automatically changed from
PIPRES-349-abstract-subscription-order-total-provider
to
PIPRES-349-enable-subscription-carrier-change
December 11, 2023 09:31
mandan2
force-pushed
the
PIPRES-349-subscription-carrier-data-provider
branch
from
f665063 to
faeb933
Compare
mandan2
merged commit da026f4
into
PIPRES-349-enable-subscription-carrier-change
5 checks passed
JevgenijVisockij
pushed a commit
that referenced
this pull request
May 14, 2024
* PIPRES-349: Subscription carrier data provider * renamed service and added missing DTO * fixed return type * renamed service
JevgenijVisockij
pushed a commit
that referenced
this pull request
May 14, 2024
* PIPRES-349: Subscription carrier data provider * renamed service and added missing DTO * fixed return type * renamed service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepared data to update to be transferred via API