PIPRES-349: Append subscription carrier ID to metadata #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomjas1997
reviewed
Nov 28, 2023
| exit; | ||
| } | ||
|
|
||
| class SubscriptionCarrierDeliveryPriceProviderData |
There was a problem hiding this comment.
"Provider" does not seem needed
tomjas1997
reviewed
Nov 28, 2023
|
|
||
| class CouldNotCreateSubscriptionData extends MollieSubscriptionException | ||
| { | ||
| public static function failedToFindMolCustomer(string $email): self |
tomjas1997
merged commit ac4e891
into
PIPRES-349-enable-subscription-carrier-change
5 checks passed
mandan2
deleted the
PIPRES-349-append-subscription-carrier-id-to-metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added currently active subscription carrier ID to Mollie payment's metadata. Added checks to see if currently active carrier is the same as set in the order. Current idea is to have same carrier for all of the subscriptions.
Improved some repositories to use abstractRepository and be injected via interface.