PIPRES-348: Move subscription options to subscription tab #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mandan2
commented
Oct 17, 2023
•
mandan2
commented
mandan2
changed the title
tomjas1997
reviewed
Oct 23, 2023
|
|
||
| /** @var Mollie */ | ||
| protected $module; | ||
|
|
||
| public function __construct() | ||
| { | ||
| parent::__construct(); | ||
| $this->leagueContainer = new LeagueServiceContainerProvider(); | ||
|
|
||
| $this->serviceProvider = new LeagueServiceContainerProvider(); |
There was a problem hiding this comment.
dont really like this approach you already have $this->module, you can getService as intended now, by using new you are skipping extendable options of this provider.
tomjas1997
reviewed
Oct 23, 2023
| * | ||
| * @throws \Throwable | ||
| */ | ||
| private function processForm(FormHandlerInterface $formHandler, Request $request) |
There was a problem hiding this comment.
Seems weird, you are calling submit, but check if it's submitted later on there should be a better solution inside Core of PS.
tomjas1997
reviewed
Oct 23, 2023
| */ | ||
| public function validateConfiguration(array $configuration): bool | ||
| { | ||
| return isset( |
tomjas1997
approved these changes
Oct 24, 2023
mandan2
deleted the
PIPRES-348-move-subscription-options-to-subscriptions-tab
branch
JevgenijVisockij
pushed a commit
that referenced
this pull request
Jan 16, 2024
* PIPRES-348: WIP move subscription options to subscription tab * added carrier repository to provide with carrier choices, moved template to another file * phpstan * adjusted PS 1.7.6 support * removed validations from formProcess * simplified formProcess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.