PIPRES-342: PsAccounts and cloudsync connect #826
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mandan2
commented
Oct 9, 2023
•
mandan2
commented
tomjas1997
reviewed
Oct 9, 2023
| return ''; | ||
| } | ||
|
|
||
| $isShopContext = Shop::getContext() === Shop::CONTEXT_SHOP; |
There was a problem hiding this comment.
does not seem to be needed variable
There was a problem hiding this comment.
Removed redundant variable
tomjas1997
approved these changes
Oct 9, 2023
* PIPRES-113: Billie payment method validation (#783) * PIPRES-113: Billie payment method validation * added missing services to base service provider * wrong method call fix * missing repository * PIPRES-113: Billie payment method setup (#788) * PIPRES-113: Billie payment method additional data send (#789)
This reverts commit 0f70ace.
* PIPRES-338: Mixed cart subscription listing improvements * added rounding for total price and moved part of install improvements to main install file * fix * added mandate_id append to upgrade file too * fix
* PIPRES-261: shipping option module setting (#814) * PIPRES-261: Shipping option module setting * csfixer * install and uninstall subscription configuration * improved faq page * PIPRES-333: Missing registered interface (#816) * PIPRES-261: Get carrier price to create subscription (#817) * PIPRES-261: Get carrier price to create subscription * updated subscription faq * renamed some services and added additional conditions for carrier retrieve * addedd back to exception codes * PIPRES-261: Set carrier for recurring order (#818) * PIPRES-261: Get carrier price to create subscription * renamed some services and added additional conditions for carrier retrieve * PIPRES-261: Set carrier for recurring order * PIPRES-261: Subscription order detail view refactoring (#819) * PIPRES-261: Get carrier price to create subscription * renamed some services and added additional conditions for carrier retrieve * addedd back to exception codes * PIPRES-261: Subscription order detail view refactoring * phpstan * PIPRES-261: Minor improvements (#820) * PIPRES-261: Get carrier price to create subscription * renamed some services and added additional conditions for carrier retrieve * PIPRES-261: Minor improvements * PIPRES-261: Create fresh specific price (#822) * PIPRES-261: Restrict BO subscription list for all shops (#823) * PIPRES-261: Restrict BO subscription list for all shops * fixed redundant error mesage
mandan2
force-pushed
the
PIPRES-342-psaccounts-and-cloudsync-connect
branch
from
2ef5693 to
038bea3
Compare
|
Too much to rebase (112 commits), will create new branch with all needed changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.