PIPRES-349: Update subscription action

mollie.php

@@ -31,7 +31,6 @@
 use Mollie\Subscription\Install\DatabaseTableInstaller;
 use Mollie\Subscription\Install\HookInstaller;
 use Mollie\Subscription\Install\Installer;
-use Mollie\Subscription\Logger\NullLogger;
 use Mollie\Subscription\Provider\SubscriptionProductProvider;
 use Mollie\Subscription\Repository\LanguageRepository as LanguageAdapter;
 use Mollie\Subscription\Repository\RecurringOrderRepositoryInterface;
@@ -179,7 +178,7 @@ public function install()
         $subscriptionInstaller = new Installer(
             new DatabaseTableInstaller(),
             new AttributeInstaller(
-                new NullLogger(),
+                $this->getService(PrestaLoggerInterface::class),
                 $this->getService(ConfigurationAdapter::class),
                 $this,
                 new LanguageAdapter(),

src/Logger/PrestaLogger.php

@@ -22,6 +22,7 @@
 
 class PrestaLogger implements PrestaLoggerInterface
 {
+    // TODO move this as a shared service for subscriptions and main source
     // TODO refactor whole logger logic and implement leftover methods
 
     /** @var ConfigurationAdapter */

src/ServiceProvider/BaseServiceProvider.php

@@ -108,8 +108,6 @@
 use Mollie\Subscription\Grid\Accessibility\SubscriptionCancelAccessibility;
 use Mollie\Subscription\Install\Installer;
 use Mollie\Subscription\Install\InstallerInterface;
-use Mollie\Subscription\Logger\Logger;
-use Mollie\Subscription\Logger\LoggerInterface;
 use Mollie\Subscription\Repository\CombinationRepository;
 use Mollie\Subscription\Repository\CombinationRepositoryInterface;
 use Mollie\Subscription\Repository\OrderDetailRepository;
@@ -149,7 +147,6 @@ public function __construct($extendedServices)
     public function register(Container $container)
     {
         /* Logger */
-        $this->addService($container, LoggerInterface::class, $container->get(Logger::class));
         $this->addService($container, PrestaLoggerInterface::class, $container->get(PrestaLogger::class));
 
         /* Utility */

subscription/Action/CreateRecurringOrderAction.php

@@ -12,10 +12,10 @@
 
 namespace Mollie\Subscription\Action;
 
+use Mollie\Logger\PrestaLoggerInterface;
 use Mollie\Subscription\DTO\CreateRecurringOrderData;
 use Mollie\Subscription\Exception\CouldNotCreateRecurringOrder;
 use Mollie\Subscription\Exception\MollieSubscriptionException;
-use Mollie\Subscription\Logger\LoggerInterface;
 use Mollie\Subscription\Utility\ClockInterface;
 
 if (!defined('_PS_VERSION_')) {
@@ -24,13 +24,13 @@
 
 class CreateRecurringOrderAction
 {
-    /** @var LoggerInterface */
+    /** @var PrestaLoggerInterface */
     private $logger;
     /** @var ClockInterface */
     private $clock;
 
     public function __construct(
-        LoggerInterface $logger,
+        PrestaLoggerInterface $logger,
         ClockInterface $clock
     ) {
         $this->logger = $logger;

subscription/Action/CreateRecurringOrdersProductAction.php

@@ -12,22 +12,22 @@
 
 namespace Mollie\Subscription\Action;
 
+use Mollie\Logger\PrestaLoggerInterface;
 use Mollie\Subscription\DTO\CreateRecurringOrdersProductData;
 use Mollie\Subscription\Exception\CouldNotCreateRecurringOrdersProduct;
 use Mollie\Subscription\Exception\MollieSubscriptionException;
-use Mollie\Subscription\Logger\LoggerInterface;
 
 if (!defined('_PS_VERSION_')) {
     exit;
 }
 
 class CreateRecurringOrdersProductAction
 {
-    /** @var LoggerInterface */
+    /** @var PrestaLoggerInterface */
     private $logger;
 
     public function __construct(
-        LoggerInterface $logger
+        PrestaLoggerInterface $logger
     ) {
         $this->logger = $logger;
     }

subscription/Action/UpdateSubscriptionAction.php

@@ -0,0 +1,55 @@
+<?php
+/**
+ * Mollie       https://www.mollie.nl
+ *
+ * @author      Mollie B.V. <[email protected]>
+ * @copyright   Mollie B.V.
+ * @license     https://github.com/mollie/PrestaShop/blob/master/LICENSE.md
+ *
+ * @see        https://github.com/mollie/PrestaShop
+ * @codingStandardsIgnoreStart
+ */
+
+namespace Mollie\Subscription\Action;
+
+use Mollie\Logger\PrestaLoggerInterface;
+use Mollie\Subscription\Api\SubscriptionApi;
+use Mollie\Subscription\DTO\UpdateSubscriptionData;
+use Mollie\Subscription\Exception\CouldNotUpdateSubscription;
+use Mollie\Subscription\Exception\MollieSubscriptionException;
+
+if (!defined('_PS_VERSION_')) {
+    exit;
+}
+
+class UpdateSubscriptionAction
+{
+    /** @var SubscriptionApi */
+    private $subscriptionApi;
+    /** @var PrestaLoggerInterface */
+    private $logger;
+
+    public function __construct(
+        SubscriptionApi $subscriptionApi,
+        PrestaLoggerInterface $logger
+    ) {
+        $this->subscriptionApi = $subscriptionApi;
+        $this->logger = $logger;
+    }
+
+    /**
+     * @throws MollieSubscriptionException
+     */
+    public function run(UpdateSubscriptionData $data): void
+    {
+        $this->logger->info(sprintf('%s - Function called', __METHOD__));
+
+        try {
+            $this->subscriptionApi->updateSubscription($data);
+        } catch (\Throwable $exception) {
+            throw CouldNotUpdateSubscription::failedToUpdateSubscription($exception, $data->getSubscriptionId());
+        }
+
+        $this->logger->info(sprintf('%s - Function ended', __METHOD__));
+    }
+}

subscription/Exception/CouldNotUpdateSubscription.php

@@ -0,0 +1,32 @@
+<?php
+/**
+ * Mollie       https://www.mollie.nl
+ *
+ * @author      Mollie B.V. <[email protected]>
+ * @copyright   Mollie B.V.
+ * @license     https://github.com/mollie/PrestaShop/blob/master/LICENSE.md
+ *
+ * @see        https://github.com/mollie/PrestaShop
+ * @codingStandardsIgnoreStart
+ */
+
+namespace Mollie\Subscription\Exception;
+
+if (!defined('_PS_VERSION_')) {
+    exit;
+}
+
+class CouldNotUpdateSubscription extends MollieSubscriptionException
+{
+    public static function failedToUpdateSubscription(\Throwable $exception, string $subscriptionId): self
+    {
+        return new self(
+            sprintf(
+                'Failed to update subscription. Subscription ID: (%s)',
+                $subscriptionId
+            ),
+            ExceptionCode::ORDER_FAILED_TO_UPDATE_SUBSCRIPTION,
+            $exception
+        );
+    }
+}

subscription/Install/AttributeInstaller.php

@@ -18,8 +18,8 @@
 use Mollie;
 use Mollie\Adapter\ConfigurationAdapter;
 use Mollie\Adapter\ProductAttributeAdapter;
+use Mollie\Logger\PrestaLoggerInterface;
 use Mollie\Subscription\Config\Config;
-use Mollie\Subscription\Logger\LoggerInterface;
 use Mollie\Subscription\Repository\LanguageRepository;
 use PrestaShopDatabaseException;
 use PrestaShopException;
@@ -43,14 +43,14 @@ class AttributeInstaller extends AbstractInstaller
     /** @var LanguageRepository */
     private $language;
 
-    /** @var LoggerInterface */
+    /** @var PrestaLoggerInterface */
     private $logger;
 
     /** @var ProductAttributeAdapter */
     private $productAttributeAdapter;
 
     public function __construct(
-        LoggerInterface $logger,
+        PrestaLoggerInterface $logger,
         ConfigurationAdapter $configuration,
         Mollie $module,
         LanguageRepository $language,

subscription/Install/AttributeUninstaller.php

@@ -17,8 +17,8 @@
 use Mollie;
 use Mollie\Adapter\ConfigurationAdapter;
 use Mollie\Adapter\ProductAttributeAdapter;
+use Mollie\Logger\PrestaLoggerInterface;
 use Mollie\Subscription\Config\Config;
-use Mollie\Subscription\Logger\LoggerInterface;
 use PrestaShopException;
 use Psr\Log\LogLevel;
 
@@ -36,13 +36,13 @@ class AttributeUninstaller extends AbstractUninstaller
     /** @var Mollie */
     private $module;
 
-    /** @var LoggerInterface */
+    /** @var PrestaLoggerInterface */
     private $logger;
     /** @var ProductAttributeAdapter */
     private $productAttributeAdapter;
 
     public function __construct(
-        LoggerInterface $logger,
+        PrestaLoggerInterface $logger,
         ConfigurationAdapter $configuration,
         Mollie $module,
         ProductAttributeAdapter $productAttributeAdapter