[PIPRES-468] fixed Gytautas comments

mollie · Nov 20, 2024 · 4a9055e · 4a9055e
1 parent f1ebcda
commit 4a9055e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/src/Config/Config.php b/src/Config/Config.php
@@ -169,7 +169,6 @@ class Config
     const MOLLIE_SUBSCRIPTION_ENABLED = 'MOLLIE_SUBSCRIPTION_ENABLED';
 
     const MOLLIE_METHOD_ENABLED = 'MOLLIE_METHOD_ENABLED_';
-    //todo array
     const MOLLIE_METHOD_TITLE = 'MOLLIE_METHOD_TITLE_';
     const MOLLIE_METHOD_API = 'MOLLIE_METHOD_API_';
     const MOLLIE_METHOD_DESCRIPTION = 'MOLLIE_METHOD_DESCRIPTION_';

diff --git a/src/Repository/MultiLangRepository.php b/src/Repository/MultiLangRepository.php
@@ -14,6 +14,10 @@
 
 use Mollie\Shared\Infrastructure\Repository\AbstractRepository;
 
+if (!defined('PS_VERSION')) {
+    exit;
+}
+
 class MultiLangRepository extends AbstractRepository implements MultiLangRepositoryInterface
 {
     public function __construct()
@@ -45,14 +49,14 @@ public function getExistingRecordId(string $idPaymentMethod, int $langId, int $i
         return \Db::getInstance()->getValue($sql) ?: null;
     }
 
-    public function getAllTranslationsByMethod(string $idPaymentMethod, int $langId, int $idShop): array
+    public function getAllTranslationsByMethod(string $idPaymentMethod, int $idShop): array
     {
         $sql = new \DbQuery();
         $sql->select('`id_lang`, `text`');
         $sql->from('mol_payment_method_lang');
         $sql->where('`id_method` = "' . pSQL($idPaymentMethod) . '"');
         $sql->where('`id_shop` = ' . $idShop);
 
-        return \Db::getInstance()->executeS($sql);
+        return \Db::getInstance()->executeS($sql) ?? [];
     }
 }
diff --git a/src/Repository/MultiLangRepositoryInterface.php b/src/Repository/MultiLangRepositoryInterface.php
@@ -37,5 +37,5 @@ public function getExistingRecordId(string $idPaymentMethod, int $langId, int $i
      * @param string $idMethod
      * @return array [id_lang => text] for instance: [74 => 'Apelo Pay', 68 => 'Apella Pia']
      */
-    public function getAllTranslationsByMethod(string $idPaymentMethod, int $langId, int $idShop): ?array;
+    public function getAllTranslationsByMethod(string $idPaymentMethod, int $idShop): ?array;
 }
diff --git a/src/Service/PaymentMethodLangService.php b/src/Service/PaymentMethodLangService.php
@@ -57,7 +57,7 @@ public function trans(string $idMethod): ?string
 
     public function getTransList(string $idMethod): array
     {
-        $result = $this->multiLangRepository->getAllTranslationsByMethod($idMethod, $this->context->getLanguageId(), $this->context->getShopId());
+        $result = $this->multiLangRepository->getAllTranslationsByMethod($idMethod, $this->context->getShopId());
 
         $mappedArray = [];
         foreach ($result as $value) {