Support Ruby 2.7+ Pattern Matching #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molawson
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
I love how remarkably simple the implementation is here. And I think the use case makes perfect sense!
In fact, I've had an open issue for... a while 😬 ... to build this sort of human readable representation of a schedule.
Would you mind adding an example to the readme?
Add `#deconstruct_keys` to `Expression::Base` and `Schedule` so that
they can be used in pattern matches.
In our products, we've been using `#to_h` for this, and it would be
nice sugar to have it built in.
A common example we've used in our products is building a
humanized-readable version of a schedule. An extremely stripped down
version might look something like this
```ruby
case existing_user_schedule
in weekday: { weekday: }
"Every #{weekday}"
in day_in_month: { day: }
"Last #{day} of every month"
end
```
danielma
force-pushed
the
dma/schedule-pattern-match
branch
from
fb1d64e to
3e595c4
Compare
|
Added an example to the readme! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
#deconstruct_keystoExpression::BaseandScheduleso that they can be used in pattern matches.In our products, we've been using
#to_hfor this, and it would be nice sugar to have it built in.A common example we've used in our products is building a humanized-readable version of a schedule. An extremely stripped down version might look something like this