Fixed issue with createQuoteExtension (#214)

mojaloop · May 22, 2020 · 1e1cd38 · 1e1cd38
1 parent e25fe98
commit 1e1cd38
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 14 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -2,7 +2,7 @@
   "name": "quoting-service",
   "description": "Quoting Service hosted by a scheme",
   "license": "Apache-2.0",
-  "version": "10.2.1",
+  "version": "10.2.2",
   "author": "ModusBox",
   "contributors": [
     "James Bush <[email protected]>",
@@ -60,12 +60,12 @@
   "dependencies": {
     "@hapi/good": "9.0.0",
     "@hapi/hapi": "18.4.1",
-    "@mojaloop/central-services-error-handling": "10.2.1",
+    "@mojaloop/central-services-error-handling": "10.2.2",
     "@mojaloop/central-services-logger": "9.5.1",
     "@mojaloop/central-services-shared": "10.2.0",
     "@mojaloop/event-sdk": "9.5.2",
     "@mojaloop/ml-number": "8.2.0",
-    "@mojaloop/sdk-standard-components": "10.2.3",
+    "@mojaloop/sdk-standard-components": "10.2.4",
     "axios": "0.19.2",
     "blipp": "4.0.1",
     "eslint-config-standard": "14.1.1",

diff --git a/src/data/database.js b/src/data/database.js
@@ -981,7 +981,7 @@ class Database {
      * @returns {object}
      * @param   {Array[{object}]} extensions - array of extension objects with quoteId, key and value properties
      */
-  async createQuoteExtensions (txn, extensions, quoteId, transactionId, quoteResponseId = undefined) {
+  async createQuoteExtensions (txn, extensions, quoteId, transactionId = undefined, quoteResponseId = undefined) {
     try {
       const newExtensions = extensions.map(({ key, value }) => ({
         quoteId,

diff --git a/src/model/quotes.js b/src/model/quotes.js
@@ -538,8 +538,7 @@ class QuotesModel {
         if (quoteUpdateRequest.extensionList &&
             Array.isArray(quoteUpdateRequest.extensionList.extension)) {
           refs.extensions = await this.db.createQuoteExtensions(
-            txn, quoteUpdateRequest.extensionList.extension, quoteId, quoteUpdateRequest.transactionId,
-            refs.quoteResponseId)
+            txn, quoteUpdateRequest.extensionList.extension, quoteId, null, refs.quoteResponseId)
         }
 
         // todo: create any additional quoteParties e.g. for fees, comission etc...

diff --git a/test/unit/model/quotes.test.js b/test/unit/model/quotes.test.js
@@ -1453,7 +1453,7 @@ describe('QuotesModel', () => {
         mockTransaction,
         mockData.quoteUpdate.extensionList.extension,
         mockData.quoteId,
-        mockData.transactionId,
+        null,
         mockQuoteResponseId
       )