fix: don't try to discover shared item version in case of custom version or invalid package name #131

mshima · 2024-10-03T21:12:52Z

Exposing a local share causes lots of errors in console:

Error: Cannot find module '@/package.json'
Require stack:
- /Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs
    at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15)
    at Module._load (node:internal/modules/cjs/loader:981:27)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:177:18)
    at normalizeShareItem (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:296:15)
    at /Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:335:21
    at Array.forEach (<anonymous>)
    at normalizeShared (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:334:25)
    at normalizeModuleFederationOptions (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:379:13)
    at federation (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:1236:17) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs'
  ]
}
Error: Cannot find module '@/package.json'
Require stack:
- /Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs
    at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15)
    at Module._load (node:internal/modules/cjs/loader:981:27)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:177:18)
    at normalizeShareItem (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:296:15)
    at /Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:335:21
    at Array.forEach (<anonymous>)
    at normalizeShared (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:334:25)
    at normalizeModuleFederationOptions (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:379:13)
    at federation (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:1236:17) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs'
  ]
}
Error: Cannot find module '@/package.json'
Require stack:
- /Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs
    at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15)
    at Module._load (node:internal/modules/cjs/loader:981:27)
    at Module.require (node:internal/modules/cjs/loader:1231:19)
    at require (node:internal/modules/helpers:177:18)
    at normalizeShareItem (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:296:15)
    at /Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:335:21
    at Array.forEach (<anonymous>)
    at normalizeShared (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:334:25)
    at normalizeModuleFederationOptions (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:379:13)
    at federation (/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs:1236:17) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/mshima/git/jhipster-samples/vite-mf/notification/node_modules/@module-federation/vite/lib/index.cjs'
  ]
}

mshima · 2024-10-04T18:25:32Z

src/utils/normalizeModuleFederationOptions.ts

  // 匹配npm包名的正则表达式，忽略路径部分
-  const regex = /^(?:@[^/]+\/)?[^/]+/;
+  const regex = /^(?:@[^/]+\/)?\w[^/]+/;


A valid package starts with a letter.

mshima · 2024-10-04T18:27:21Z

src/utils/normalizeModuleFederationOptions.ts

-    console.log(e);
+  let { version, requiredVersion }: any = typeof shareItem === 'object' ? shareItem : {};
+  if (!version) {
+    const npmPackage = removePathFromNpmPackage(key);


Aliases probably should take precedence over packages.

mshima · 2024-10-04T18:28:11Z

src/utils/normalizeModuleFederationOptions.ts

-    options.shared[removePathFromNpmPackage(key)] ||
-    options.shared[removePathFromNpmPackage(key) + '/'];
-  return shareItem;
+  return options.shared[key];


removePathFromNpmPackage() doesn't looks to be applied when creating the shared object.

zhangHongEn · 2024-10-05T02:35:20Z

How to configure “shared”? Do Webpack or Rust have this feature?

zhangHongEn · 2024-10-05T02:41:58Z

Understood, I will review it later.

zhangHongEn · 2024-10-07T15:55:17Z

Thank you for your contribution, but this feature requires some additional handling, and I will complete it this week.

zhangHongEn · 2024-10-07T16:02:14Z

There is one more step left for the proxy logic to convert relative paths to absolute paths. I will find time this week to complete it.

gioboa · 2024-10-21T09:39:13Z

Are there any news on this one?

zhangHongEn · 2024-10-21T14:28:03Z

I've been really busy lately, working overtime for the weekend and not being able to handle this issue in a timely manner

…

mshima · 2024-10-21T14:37:11Z

Maybe shared management should be handled by https://github.com/module-federation/core/blob/main/packages/managers/src/SharedManager.ts

zhangHongEn · 2024-10-21T14:42:29Z

Maybe shared management should be handled by https://github.com/module-federation/core/blob/main/packages/managers/src/SharedManager.ts

Yes, unifying the logic is better. You can submit a PR to fix this issue, but implementing shared relative paths will be different from the current process of sharing npm packages.

zhangHongEn · 2024-10-29T11:05:02Z

I really don’t have time to add this feature, but can use Delegate Modules.

zhangHongEn · 2024-10-29T11:48:21Z

or use shared-library
https://github.com/module-federation/module-federation-examples/tree/master/shared-context

mshima marked this pull request as draft October 3, 2024 21:15

mshima closed this Oct 4, 2024

mshima reopened this Oct 4, 2024

mshima changed the title ~~fix: do not show stack trace if shared resource is a internal share.~~ fix: don't try to discover shared item version in case of custom version and invalid package name Oct 4, 2024

fix: use provided version

326fce5

mshima force-pushed the patch-1 branch from f6a1836 to 326fce5 Compare October 4, 2024 18:01

mshima added 2 commits October 4, 2024 15:13

Update normalizeModuleFederationOptions.ts

7fc1b6c

Update normalizeModuleFederationOptions.ts

c75dab7

mshima commented Oct 4, 2024

View reviewed changes

mshima marked this pull request as ready for review October 4, 2024 18:28

mshima changed the title ~~fix: don't try to discover shared item version in case of custom version and invalid package name~~ fix: don't try to discover shared item version in case of custom version or invalid package name Oct 4, 2024

mshima mentioned this pull request Oct 7, 2024

Switch Vue microfrontends to use recently released @module-federation/[email protected] jhipster/generator-jhipster#27489

Open

1 task

zhangHongEn added a commit to zhangHongEn/vite that referenced this pull request Oct 7, 2024

feat: share custom path module-federation#131

a57000b

zhangHongEn added a commit to zhangHongEn/vite that referenced this pull request Oct 7, 2024

feat: share custom path module-federation#131

33aab58

zhangHongEn mentioned this pull request Oct 29, 2024

feat: shared-directory module-federation/module-federation-examples#4299

Closed

zhangHongEn mentioned this pull request Oct 29, 2024

feat: shared-directory module-federation/module-federation-examples#4300

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: don't try to discover shared item version in case of custom version or invalid package name #131

fix: don't try to discover shared item version in case of custom version or invalid package name #131

mshima commented Oct 3, 2024 •

edited

Loading

mshima Oct 4, 2024

mshima Oct 4, 2024

mshima Oct 4, 2024

zhangHongEn commented Oct 5, 2024

zhangHongEn commented Oct 5, 2024

zhangHongEn commented Oct 7, 2024

zhangHongEn commented Oct 7, 2024

gioboa commented Oct 21, 2024 •

edited

Loading

zhangHongEn commented Oct 21, 2024 via email

mshima commented Oct 21, 2024

zhangHongEn commented Oct 21, 2024

zhangHongEn commented Oct 29, 2024 •

edited

Loading

zhangHongEn commented Oct 29, 2024

fix: don't try to discover shared item version in case of custom version or invalid package name #131

Are you sure you want to change the base?

fix: don't try to discover shared item version in case of custom version or invalid package name #131

Conversation

mshima commented Oct 3, 2024 • edited Loading

mshima Oct 4, 2024

Choose a reason for hiding this comment

mshima Oct 4, 2024

Choose a reason for hiding this comment

mshima Oct 4, 2024

Choose a reason for hiding this comment

zhangHongEn commented Oct 5, 2024

zhangHongEn commented Oct 5, 2024

zhangHongEn commented Oct 7, 2024

zhangHongEn commented Oct 7, 2024

gioboa commented Oct 21, 2024 • edited Loading

zhangHongEn commented Oct 21, 2024 via email

mshima commented Oct 21, 2024

zhangHongEn commented Oct 21, 2024

zhangHongEn commented Oct 29, 2024 • edited Loading

zhangHongEn commented Oct 29, 2024

mshima commented Oct 3, 2024 •

edited

Loading

gioboa commented Oct 21, 2024 •

edited

Loading

zhangHongEn commented Oct 29, 2024 •

edited

Loading