Add I2C peripheral data for all devices #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I2C IP typed stm32l4 and stm32-extended are merged. A feature for 'fast mode plus' is added.
I'd deal with that in the templates for now. I'm not sure how much of the memory map should be part of these files. I think in the long term I would want to query the memory map in Python too, but then the data needs to be better than what SVD currently gives us. I've parsed the CMSIS Header files with some success before, but that's not included here yet. Is this PR ready to go from your side? |
|
I'm fine with the PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the necessary data for solving modm issue #101.
What should we do about the F4 FMPI2C? The hardware is identical to the
stm32-extendedI2C but it is named FMPI2Cx. The peripheral is not listed at all in stm_peripherals.py.The raw data contains instance specific feature tags which can't be modeled in the device files right now (see #7).