fix(gridintersect): typo shapely function call within gridintersect #2342 #2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix typo in shapely.multilinestrings - fix issue with np.apply_along_axis - consider geometry collections when computing overlaps - add test for vertex mode - add inactive test for structured mode (not yet working)
dbrakenhoff
changed the title
This was referenced Oct 22, 2024
wpbonelli
approved these changes
Oct 25, 2024
langevin-usgs
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2342
Notes:
np.apply_along_axiswas reducing result from multiple GeometryCollections to a single MultiLineString causing duplication of shapes in the intersection result.The test for GeometryCollections in "structured"-mode is commented out as it was failing and I don't have the time at the moment to figure that out. I will open a separate issue, along with some other GridIntersect to-do's (see #2344).EDIT: structured support will be dropped in future releases (see #2344).