wip: Storybook 8 #2816
wip: Storybook 8 #2816
Conversation
🦋 Changeset detectedLatest commit: 723ad59 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ature/storybook-8
…quivalent to 'undefined' at the top level of an ES module, and has been rewritten"
|
there are pipeline errors, so those are the minimum that such migration need to cover in general our Storybook pipeline is pretty reliable in testing even such big changes like this PR, but a few things I always needed to check manually, specifically everything related to path resolution, because paths work very differently when you test within a subpackage which is part of a bigger monorepo like modern-web and inside a simple project, also differently when it's an actual published NPM package and when it's a symlink, so I'm afraid I'll need to conduct more tests manually after the pipeline is green my team has been planning to work on this in this autumn, can't give specific timelines, but sooner than later |
|
Thank you for the review, i didnt have historical context of the monorepo, so i will revert some of the changes for unmaintained tools Also i forgot to tell but this PR is work in progress |
| @@ -46,7 +46,8 @@ | |||
| "@rocket/cli": "^0.10.1", | |||
| "@rocket/core": "^0.1.2", | |||
| "@rocket/launch": "^0.6.0", | |||
| "@rocket/search": "^0.6.0" | |||
| "@rocket/search": "^0.6.0", | |||
| "@storybook/core": "^8.3.3" | |||
There was a problem hiding this comment.
This shouldn't be needed, you should be able to depend on storybook instead, I hope
There was a problem hiding this comment.
storybook itself includes a lot of unrelated stuff. I only need @storybook/core/channels
There was a problem hiding this comment.
shouldn't this be in one of the packages, rather that the monorepo root?
| @@ -2,19 +2,11 @@ | |||
|
|
|||
| export async function generateSetupAddonsScript() { | |||
| return ` | |||
| import { createChannel as createPostMessageChannel } from '@storybook/channel-postmessage'; | |||
| import { createChannel as createWebSocketChannel } from '@storybook/channel-websocket'; | |||
There was a problem hiding this comment.
did you remove these 2 deps? I assumed they moved stuff to core or reexport and then import from it in their own builders, is that so? if that, I think we don't need to depend on these 2 packages directly anymore
There was a problem hiding this comment.
one if those channels is not longer maintained, another one is a part of the core now
based on #2674
What I did