-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] OP-wise Insight Mining #516
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…analyze the target dataset
- support set the number of samples to be analyzed in auto mode. It's 1k in default.
- optimize the logics of loading filters that produce stats and updating attributes of OPs
- suppress the error/exceptions in Monitor due to the termination of the main process - exported stats file includes meta field in exporter
HYLcool
added
enhancement
New feature or request
dj:core
issues/PRs about the core functions of Data-Juicer
labels
Dec 19, 2024
# Conflicts: # data_juicer/ops/__init__.py # data_juicer/ops/base_op.py
# Conflicts: # data_juicer/config/config.py # data_juicer/core/analyzer.py
yxdyc
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, plz see the minor comments.
BeachWang
reviewed
Dec 20, 2024
yxdyc
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run
method of analyzer instead of loading from disk.export_stats
is True.specified_field_filter
,specified_numeric_field_filter
,suffix_filter
,video_tagging_from_frames_filter
(produces tags instead of stats).video_tagging_from_frames_filter
,image_tagging_mapper
,video_tagging_from_audio_mapper
,video_tagging_from_frames_mapper
This PR is based on the PR #512 . Please review that PR first before reviewing this one.