-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't set the value of a DateTimeField with auto_now or auto_now_add #23 #451
Conversation
I've faced an issue similar to this and gave it a go. One issue with this implementation is that it only works if either I could call |
@rodbv oh, many thanks for this attempt to tackle an annoying issue! 👍 This is promising! Best, |
@amureki thanks! I've fixed the tests and the linter error. When running the tests workflow on my repo there's an error on the ruff linter but it seems to be a setup issue. Edit: Some tests are still failing with timezone issues, I'll get to them |
I've dealt with my test failing depending on the use_tz setting. Ruff linter is still failing, is there anything I can do? |
Thanks for fixing the tests! I'll take a look into tz stuff before the end of this week. And also will do a proper check on your code. Sorry for the complications on the contribution way. |
@rodbv I finally got some time and figured the issue. This was happening due to I also went ahead and fixed the last ruff problem, so it is good to go now, I am going to merge it and release now! |
I released it as 1.17.0 |
Awesome! Thanks a lot for the support and for being so welcoming, I'm looking forward to contribute more, I'll have another look at the list of open issues :) |
@rodbv well, thank you for the contribution, patience and kind words, much appreciated! ✨ |
Describe the change
A clear and concise description of what the change is.
PR Checklist