Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Logging #37

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Better Logging #37

merged 6 commits into from
Dec 19, 2024

Conversation

dimitribouniol
Copy link
Member

  • Updated the main logger logic to use a fallback logger rather than a child logger, based on feedback from slack
  • Renamed WebPushManager's logger to backgroundActivityLogger to match AsyncHTTPClient's use of a similar logger.
  • Added loggers to the send methods.
  • Added much more comprehensive logging metadata.
  • Fixed the logging level of service logs to one appropriate for libraries.
  • Fixed some missing backticks on documentation.

@dimitribouniol dimitribouniol self-assigned this Dec 19, 2024
@dimitribouniol dimitribouniol enabled auto-merge (rebase) December 19, 2024 11:10
@dimitribouniol dimitribouniol merged commit ce3a7df into main Dec 19, 2024
2 of 3 checks passed
@dimitribouniol dimitribouniol deleted the dimitri/better-logging branch December 19, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant