Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #10

wants to merge 1 commit into from

Conversation

tardyp
Copy link

@tardyp tardyp commented Jan 9, 2020

No description provided.

Copy link

@brcaswell brcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with suggestion.

Comment on lines +14 to +17
```powershell
cd "C:\ProgramData\docker"
.\docker-ci-zap.exe -folder "."
```

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the original instructions, for you should pass the full path in -folder argument (as it's unlikely to be different); however, putting the executable in your ProgramData folder isn't necessary, likely, nor recommend. people install tools in tools folders not data folders

@brcaswell
Copy link

brcaswell commented Mar 1, 2020

How did you get around TrustedInstaller owning some directories and files in subdirectories of windowsfilter layer folders that cause Access Denied issues when attempting these steps? or did you not encounter such issues?

@@ -1,4 +1,23 @@
This program will call the hcship.DestroyLayer system call on the specified folder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hcsshim...


run file:
This will effectively reclaim a lot of hard-drive space for an undocumented reason.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps document it here..... All the API actually does is take back-up privileges and effectively do the linux-equivalent to rm -rf or PowerShell Remove-Item -Recurse -Force. Also a lot is highly subjective. Please be specific and say exactly what it is removing when used correctly (and potentially very dangerously).


```powershell
net start docker
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may well be necessary to reboot between 1 and 2 to ensure there are no containers running which have ref counts to files which cannot be removed.

@dazinator
Copy link

Note: this executable errors if you don't have the hyper-v platform windows feature enabled, this seems to be a pre-requisite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants