fix: valora app version check for Aave positions #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satish-ravi
approved these changes
Dec 2, 2024
| @@ -322,6 +326,37 @@ describe('GET /getPositions', () => { | |||
| data: TEST_POSITIONS_CELO, | |||
| }) | |||
| }) | |||
|
|
|||
| for (const [userAgent, shouldIncludeAave] of [ | |||
There was a problem hiding this comment.
is the reason to use for loop over it.each is for better test names? or something else?
There was a problem hiding this comment.
Yes for better test name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was randomly reading the code and noticed the check to include/exclude Aave positions would fail once we hit version
1.100. Which will be the next release.This fixes it, and also defaults to including Aave for other Mobile Stack apps (any other User-Agent).
Which is what I think we want.