Skip to content

Commit

Permalink
PR feedback, update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
mlw committed Nov 11, 2024
1 parent 9bd1c3f commit bac0e60
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions Source/santad/EventProviders/EndpointSecurity/Enricher.mm
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,10 @@
UIDForUsername(
StringTokenToStringView(es_msg->event.authentication->data.auto_unlock->username))));

// Note: return nullptr here rather than exit. Unlike the programmer error case
// below which results in an exit, here we have a case of potentially new
// authentication types being added in the future for this one event type. If
// that happens, we don't want versions of Santa compiled for an older SDK to
// start exiting due to an unknown type.
// Note: There is a case here where future OS versions could add new authentication types that
// did not exist in the SDK used to build the current running version of Santa. Return nullptr
// here to signal to the caller that event processing should not continue. Santa would have to
// be updated and rebuilt with the new SDK in order to properly handle the new types.
default: return nullptr;
}
case ES_EVENT_TYPE_NOTIFY_LW_SESSION_LOGIN:
Expand Down

0 comments on commit bac0e60

Please sign in to comment.