Change auth instigator trigger field names in proto schema (northpole…

…sec#142)

This PR changes the field names for the `oneof auth_instigator` fields
to have names that are more meaningful for people using JSON event
logging.

---------

Signed-off-by: Matt W <[email protected]>
Co-authored-by: Russell Hancox <[email protected]>

Source/common/santa.proto

@@ -763,13 +763,13 @@ message AuthenticationOD {
   optional ProcessInfoLight instigator = 1;
 
   // The process that triggered authentication
-  // Note: Due internal system limitations, the process that triggered the
+  // Note: Due to macOS system limitations, the process that triggered the
   // event may have already exited before the event could be generated. This
   // results in only a small subset of the information from the triggering
   // process to be reported.
   oneof auth_instigator {
-    ProcessInfoLight process = 2;
-    ProcessID fallback_id = 3;
+    ProcessInfoLight trigger_process = 2;
+    ProcessID trigger_id = 3;
   }
 
   // OD record type against which OD is authenticating
@@ -796,13 +796,13 @@ message AuthenticationTouchID {
   optional ProcessInfoLight instigator = 1;
 
   // The process that triggered authentication
-  // Note: Due internal system limitations, the process that triggered the
+  // Note: Due to macOS system limitations, the process that triggered the
   // event may have already exited before the event could be generated. This
   // results in only a small subset of the information from the triggering
   // process to be reported.
   oneof auth_instigator {
-    ProcessInfoLight process = 2;
-    ProcessID fallback_id = 3;
+    ProcessInfoLight trigger_process = 2;
+    ProcessID trigger_id = 3;
   }
 
   enum Mode {
@@ -825,13 +825,13 @@ message AuthenticationToken {
   optional ProcessInfoLight instigator = 1;
 
   // The process that triggered authentication
-  // Note: Due internal system limitations, the process that triggered the
+  // Note: Due to macOS system limitations, the process that triggered the
   // event may have already exited before the event could be generated. This
   // results in only a small subset of the information from the triggering
   // process to be reported.
   oneof auth_instigator {
-    ProcessInfoLight process = 2;
-    ProcessID fallback_id = 3;
+    ProcessInfoLight trigger_process = 2;
+    ProcessID trigger_id = 3;
   }
 
   // Hash of the public key which CryptoTokenKit is authenticating

Source/santad/Logs/EndpointSecurity/Serializers/Protobuf.mm

@@ -984,8 +984,8 @@ void EncodeAuthInstigatorOrFallback(
 
   EncodeProcessInfoLight(pb_od->mutable_instigator(), msg);
   EncodeAuthInstigatorOrFallback(
-    msg, [pb_od] { return pb_od->mutable_process(); },
-    [pb_od] { return pb_od->mutable_fallback_id(); });
+    msg, [pb_od] { return pb_od->mutable_trigger_process(); },
+    [pb_od] { return pb_od->mutable_trigger_id(); });
 
   EncodeStringToken([pb_od] { return pb_od->mutable_record_type(); }, es_od_event->record_type);
   EncodeStringToken([pb_od] { return pb_od->mutable_record_name(); }, es_od_event->record_name);
@@ -1015,8 +1015,8 @@ void EncodeAuthInstigatorOrFallback(
 
   EncodeProcessInfoLight(pb_touchid->mutable_instigator(), msg);
   EncodeAuthInstigatorOrFallback(
-    msg, [pb_touchid] { return pb_touchid->mutable_process(); },
-    [pb_touchid] { return pb_touchid->mutable_fallback_id(); });
+    msg, [pb_touchid] { return pb_touchid->mutable_trigger_process(); },
+    [pb_touchid] { return pb_touchid->mutable_trigger_id(); });
 
   pb_touchid->set_mode(GetAuthenticationTouchIDMode(es_touchid_event->touchid_mode));
   if (es_touchid_event->has_uid) {
@@ -1038,8 +1038,8 @@ void EncodeAuthInstigatorOrFallback(
 
   EncodeProcessInfoLight(pb_token->mutable_instigator(), msg);
   EncodeAuthInstigatorOrFallback(
-    msg, [pb_token] { return pb_token->mutable_process(); },
-    [pb_token] { return pb_token->mutable_fallback_id(); });
+    msg, [pb_token] { return pb_token->mutable_trigger_process(); },
+    [pb_token] { return pb_token->mutable_trigger_id(); });
 
   EncodeStringToken([pb_token] { return pb_token->mutable_pubkey_hash(); },
                     es_token_event->pubkey_hash);

Source/santad/testdata/protobuf/v6/authentication_od.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v6/authentication_token.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v6/authentication_touchid.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v6/authentication_touchid_no_uid.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v7/authentication_od.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v7/authentication_token.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v7/authentication_touchid.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v7/authentication_touchid_no_uid.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v8/authentication_od.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v8/authentication_od_missing_auth_instigator.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "fallback_id": {
+  "trigger_id": {
    "pid": 98,
    "pidversion": 76
   },

Source/santad/testdata/protobuf/v8/authentication_token.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v8/authentication_token_missing_auth_instigator.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "fallback_id": {
+  "trigger_id": {
    "pid": 98,
    "pidversion": 76
   },

Source/santad/testdata/protobuf/v8/authentication_touchid.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45

Source/santad/testdata/protobuf/v8/authentication_touchid_missing_auth_instigator.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "fallback_id": {
+  "trigger_id": {
    "pid": 98,
    "pidversion": 76
   },

Source/santad/testdata/protobuf/v8/authentication_touchid_no_uid.json

@@ -34,7 +34,7 @@
     "truncated": false
    }
   },
-  "process": {
+  "trigger_process": {
    "id": {
     "pid": 23,
     "pidversion": 45