handle requirements as in current paradox

mlr-org · Jan 14, 2024 · bf78002 · bf78002
1 parent df23a38
commit bf78002
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/R/ParamSet.R b/R/ParamSet.R
@@ -294,12 +294,12 @@ ParamSet = R6Class("ParamSet",
       }
 
       if (check_strict) {
-        required = setdiff(self$ids(tags = "required"), ns)
-        if (length(required) > 0L) {
-          return(sprintf("Missing required parameters: %s", str_collapse(required)))
-        }
-        return(self$check_dependencies(xs))
+        ## required = setdiff(self$ids(tags = "required"), ns)
+        ## if (length(required) > 0L) {
+        ##   return(sprintf("Missing required parameters: %s", str_collapse(required)))
+        ## }
         if (!self$test_constraint(xs, assert_value = FALSE)) return(sprintf("Constraint not fulfilled."))
+        return(self$check_dependencies(xs))
       }
 
       TRUE # we passed all checks