-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add asv benchmarks to ci #69
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 93.20% 93.20%
=======================================
Files 32 32
Lines 1604 1604
=======================================
Hits 1495 1495
Misses 109 109 ☔ View full report in Codecov by Sentry. |
@xhochy I remember setting up something similar on a Quantco internal project. |
I don't see the actual error in the CI log. Can you point me to it? |
Essentially, asv fails to install the package. Possible causes:
Also, why are dependencies installed via pip and not conda? |
That's a long log but where is the actual error? All errors I see are only warnings in the end and it progresses past them. |
I'm sorry, I edited my answer. Even though the "environment_type": "conda",
...
"conda_channels": ["conda-forge"],
"conda_environment_file": "../environment.yml", to me, it looks like dependencies are installed via pip. After installing dependencies
and then the whole thing repeats for earlier commits. |
OK! Now, I understand. The problem is that The conda-forge PR fails probably due to a missing section in
|
No description provided.