feat: add matrixGetSubMatrix function #236
Open
+196
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatiny
reviewed
Mar 22, 2024
|
Please run |
targos
reviewed
Mar 22, 2024
lpatiny
reviewed
Oct 10, 2024
src/matrix/matrixGetSubMatrix.ts
Outdated
| const nbColumns = endColumn - startColumn + 1; | ||
| const nbRows = endRow - startRow + 1; | ||
|
|
||
| const subMatrix = matrixCreateEmpty({ nbColumns, nbRows }); |
There was a problem hiding this comment.
Not sure if we should not simply use ml-matrix but anyway this seems like a very slow method.
Why create an empty matrix ?
Just make a loop on the selected rows and push a 'slice'.
There was a problem hiding this comment.
I wonder also where it is being used because if we create temporary submatrix for some applications we can always create a 'subarray' https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/subarray that is a pointer to the original array (must be typed). It is very specific but we don't duplicate the data. We can discuss on telegram if it can be used in your application.
Co-authored-by: Michaël Zasso <[email protected]>
Co-authored-by: Michaël Zasso <[email protected]>
jobo322
force-pushed
the
matrixGetSubMatrix
branch
from
b534efc
to
ae8953b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.