Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add matrixSetSubMatrix #211

Merged
merged 2 commits into from
Jan 26, 2024
Merged

feat: add matrixSetSubMatrix #211

merged 2 commits into from
Jan 26, 2024

Conversation

jobo322
Copy link
Member

@jobo322 jobo322 commented Jan 25, 2024

No description provided.

@jobo322 jobo322 linked an issue Jan 25, 2024 that may be closed by this pull request
@jobo322
Copy link
Member Author

jobo322 commented Jan 25, 2024

@targos there is a eslint error related with the use of undefined. Could you check if I should refactor the function or test case.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (668cba6) 95.11% compared to head (9420cbc) 95.11%.

Files Patch % Lines
src/matrix/matrixSetSubMatrix.ts 95.83% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files         168      169    +1     
  Lines        3334     3358   +24     
  Branches      832      844   +12     
=======================================
+ Hits         3171     3194   +23     
- Misses        160      161    +1     
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lpatiny
Copy link
Member

lpatiny commented Jan 25, 2024

I don't see this error. The tests are passing correctly seems to me. Do you have the last version of the code ?

Also please add some tests of the throw. Do you see how to test errors ?

@lpatiny lpatiny merged commit 922e2cc into main Jan 26, 2024
9 checks passed
@lpatiny lpatiny deleted the 210-add-matrixsetsubmatrix branch January 26, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add matrixSetSubMatrix
2 participants