-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use rich for displaying error traceback in mlinfra cli #129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Message that will be displayed on users' first pull request
@ara-25 have you tested these changes? I tried to see rich based stacktrace, but that didn't work. |
That's strange. Are you testing by running the For me, the stack trace is showing upon running |
I'm testing it by trying to run the pyinvoke command directly, so by calling |
So, with my current implementation, the Please let me know if the formatted traceback needs to be displayed for the entire codebase and I will modify it accordingly. |
Ah alright, that makes sense. |
@aliabbasjaffri then would be great if I am able to take it up as part of a separate issue :) |
Just tested and verified. Thank you for your contribution. If you are interested in contributing further and extending rich to the rest of the codebase, do let me know. |
Thanks @aliabbasjaffri I am interested on working further on integrating rich in mlinfra. Feel free to assign any future tasks |
hey @ara-25 , i managed to create a new issue for rich integration across entire codebase. Please let me know if you need any more context of help regarding this. You can reach out to me via discord channel, i'm rather fast to reply back there than on the github issues. Also, i would like to request a github ⭐ from you as that would really help the tool get more traction and users. Thank you! |
Thanks a lot @aliabbasjaffri. Also, I have already starred your amazing work |
This PR proposes the following changes
Closes #96
PR Checklist
PR Type
What kind of change does this PR introduce?