Ming/brain cc #89
Ming/brain cc #89
Conversation
…new path of the vocalic files.
…n in a different folder
…n in a different folder
…all the time steps.
…all the time steps.
…into ming/brain_cc
coordination/model/real/brain.py
Outdated
| @@ -254,18 +256,34 @@ def _create_coordination(self, bundle): | |||
| # Also include parameters for us to able to set the values of individualism, | |||
| # coordination and common cause independently when use the newly implemented 3d | |||
| # coordination modules. | |||
| coordination = SigmoidGaussianCoordination( | |||
There was a problem hiding this comment.
We don't want to remove this completely. We still want to use SigmoidGaussianCoordination when common cause is False. You should add an if/else here for bundle.common_cause.
coordination/model/real/brain.py
Outdated
| sd_uc=bundle.sd_uc, | ||
| initial_samples=bundle.initial_coordination_samples, | ||
| unbounded_coordination_observed_values=given_coordination, | ||
| include_common_cause=bundle.enable_common_cause |
There was a problem hiding this comment.
This parameter does not exist in the DirichletGaussianCoordination3D or SigmoidGaussianCoordination3D. please look at the constructors of these classes because the other parameters also changed names.
…undle.common_cause` is False, resume `SigmoidGaussianCoordination` if common cause is not enabled
…ation', update config with options for 'sd_uc_individualism' and 'sd_uc_common_cause', and apply similar changes for 'mean_uc0'. And also add these into config bundle
coordination/model/real/brain.py
Outdated
| mean_mean_uc0=bundle.mean_mean_uc0, | ||
| sd_mean_uc0=bundle.sd_mean_uc0, | ||
| initial_samples=bundle.initial_coordination_samples, | ||
| unbounded_coordination_observed_values=bundle.observed_coordination_for_inference, |
There was a problem hiding this comment.
This should be given_coordination. You need to do the same thing for individualism and common_cause. Create given_individualism and given_common_cause as logits of the unbounded values passed to the config bundle.
coordination/model/real/brain.py
Outdated
| mean_mean_uc0=bundle.mean_mean_uc0, | ||
| sd_mean_uc0=bundle.sd_mean_uc0, | ||
| initial_samples=bundle.initial_coordination_samples, | ||
| unbounded_coordination_observed_values=bundle.observed_coordination_for_inference, |
There was a problem hiding this comment.
This should be given_coordination. You need to do the same thing for individualism and common_cause. Create given_individualism and given_common_cause as logits of the unbounded values passed to the config bundle.
No description provided.