Reduce Number of concurrent sounds on O3DS. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it a noticeable difference? Is it due to the -ffastmath change? I feel like this would be better as an IFDEF thing rather than adding the 3ds specific check in the middle of the original sm64 code... |
|
It is a noticeable difference I assure you the sound crackling is finally gone. The fast math did not seem needed any more. Also I can make it an if def if you want. |
|
Also worth mentioning I bet we could boost the number of concurrent sounds on N3DS to something higher but I don't have a N3DS to test that. |
Bitl
added a commit
to Bitl/sm64-port
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the Sound Crackling on Old3DS systems at the cost of not being able to play as many sounds at once.
Changed from 16 to 9 apply s only to Old 3DS systems.