Lesson9 #12
Open
Lesson9 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eld0727
reviewed
May 10, 2021
| @PostMapping("/{city}") | ||
| @ResponseBody | ||
| fun addCity(@PathVariable city: String): String { | ||
| cityRepository.save(City(0, city)) |
There was a problem hiding this comment.
Тут всё таки должна возвращаться только что созданная сущность
eld0727
reviewed
May 10, 2021
| @Tag(name = "user", description = "The User API") | ||
| @Controller | ||
| @RequestMapping("/api/user") | ||
| class UserController(private val userRepository: UserService, private val cityRepository: CityRepository) { |
There was a problem hiding this comment.
Rest предполагает, что у тебя есть описание какого то ресурса с примерно такими операциями:
GET /api/users- получить всех пользователейGET /api/users/{id}- получить одного пользователяPOST /api/users- создать пользователяPUT /api/users/{id}- изменить пользователяDELETE /api/users/{id}- удалить пользователя
eld0727
reviewed
May 10, 2021
|
|
||
|
|
||
| @Operation(summary = "Add user", tags = ["user"]) | ||
| @PostMapping("/save/{login}/{firstname}/{lastname}/{city}") |
There was a problem hiding this comment.
Это делается через body, вот так принимать параметры максимально небезопасно, так как многие балансировщики логируют путь
eld0727
reviewed
May 10, 2021
| @PathVariable city: String): String { | ||
| val c = cityRepository.findCityByName(city) ?: throw ResponseStatusException(NOT_FOUND, "City don't exist") | ||
| userRepository.addUser(User(0, login, firstname, lastname, c.id)) | ||
| return "UserSaved" |
eld0727
reviewed
May 10, 2021
|
|
||
|
|
||
| @Operation(summary = "Update user", tags = ["user"]) | ||
| @PutMapping("/update/{id}/{login}") |
eld0727
reviewed
May 10, 2021
| import javax.persistence.* | ||
|
|
||
| @Entity | ||
| class User(@Id @GeneratedValue var id: Long? = null, |
There was a problem hiding this comment.
А для чего все значения заполнены по умолчанию?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.